def self.filenames(names)
  hsh = Hash.new(0)
  new_names = []
  names.each do |name|
    hsh[name] += 1
    if hsh[name] == 1
      if new_names.include? name
        new_names << name + "(#{hsh[name]-1})"
      else
        new_names << name
      end
    else
      new_names << name + "(#{hsh[name]-1})"
    end
  end
  new_names
end
name = ["photo", "photo", "doc", "photo(1)", "photo"]

p filenames(name) 

#["photo", "photo(1)", "doc", "photo(1)(1)", "photo(2)"]

names = ["photo", "photo", "photo(1)", "photo(1)"]

# даёт на выходе

["photo", "photo(1)", "photo(1)(1)", "photo(1)(1)"]

# а должно

["photo", "photo(1)", "photo(1)(1)", "photo(1)(2)"]